Re: [PATCH v2 00/10] soc: sunxi: sram: Fixes and D1 support

From: Conor.Dooley
Date: Mon Aug 15 2022 - 02:58:15 EST


Hey Samuel,
On 15/08/2022 05:12, Samuel Holland wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> This series cleans up a few issues in the system controller driver, and
> then expands the exported regmap to support one of the pairs of LDOs
> built in to the D1 SoC.
>
> Eventually, we will need to update the SRAM region claiming API so
> ownership can be swapped back and forth by consumer drivers. This will
> be necessary for uploading firmware to the R329/D1 DSPs, but it is not
> needed for initial bringup.

I tried this series on top of both 6.0-rc1 & next, but I saw a shed
load of errors from dtbs_check. I'll take a look at the rest of the
series later on, but just FYI. I know I have seen patches going into
different subsystems so I assume you're working on it. However, it
would be nice to let us what all the dependencies for this series are
dt-binding wise in the cover letter.
I have been trying to get riscv down to 0 warnings and would not be
in favour of accepting patches that go in the other direction.
(This patchset currently produces about 75 warnings)

Thanks,
Conor.

>
> Changes in v2:
> - New patch to first clean up the binding
>
> Samuel Holland (10):
> dt-bindings: sram: sunxi-sram: Clean up the compatible lists
> dt-bindings: sram: sunxi-sram: Add D1 compatible string
> soc: sunxi: sram: Actually claim SRAM regions
> soc: sunxi: sram: Prevent the driver from being unbound
> soc: sunxi: sram: Fix probe function ordering issues
> soc: sunxi: sram: Fix debugfs info for A64 SRAM C
> soc: sunxi: sram: Return void from the release function
> soc: sunxi: sram: Save a pointer to the OF match data
> soc: sunxi: sram: Export the LDO control register
> soc: sunxi: sram: Add support for the D1 system control
>
> .../allwinner,sun4i-a10-system-control.yaml | 82 ++++++++-----------
> drivers/soc/sunxi/sunxi_sram.c | 74 +++++++++--------
> include/linux/soc/sunxi/sunxi_sram.h | 2 +-
> 3 files changed, 73 insertions(+), 85 deletions(-)
>
> --
> 2.35.1
>