[irqchip: irq/irqchip-fixes] irqchip/loongson-liointc: Fix an error handling path in liointc_init()
From: irqchip-bot for Christophe JAILLET
Date: Fri Aug 12 2022 - 08:55:06 EST
The following commit has been merged into the irq/irqchip-fixes branch of irqchip:
Commit-ID: a9084d888fbaaed65ded56f11d052cf8b04519a5
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/a9084d888fbaaed65ded56f11d052cf8b04519a5
Author: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
AuthorDate: Mon, 01 Aug 2022 21:28:07 +02:00
Committer: Marc Zyngier <maz@xxxxxxxxxx>
CommitterDate: Fri, 12 Aug 2022 13:47:21 +01:00
irqchip/loongson-liointc: Fix an error handling path in liointc_init()
All errors lead to the error handling path, except the one dealing
with "reg-names" in DT.
Fix it and release some resources before returning if this test fails.
Fixes: 0858ed035a85 ("irqchip/loongson-liointc: Add ACPI init support")
Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
[maz: fix commit message]
Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx>
Link: https://lore.kernel.org/r/1a6d74ab70712279023aa7bdbd31bd3aec103bc0.1659382063.git.christophe.jaillet@xxxxxxxxxx
---
drivers/irqchip/irq-loongson-liointc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-loongson-liointc.c b/drivers/irqchip/irq-loongson-liointc.c
index acd1a4b..0da8716 100644
--- a/drivers/irqchip/irq-loongson-liointc.c
+++ b/drivers/irqchip/irq-loongson-liointc.c
@@ -207,7 +207,7 @@ static int liointc_init(phys_addr_t addr, unsigned long size, int revision,
"reg-names", core_reg_names[i]);
if (index < 0)
- return -EINVAL;
+ goto out_iounmap;
priv->core_isr[i] = of_iomap(node, index);
}