Re: [PATCH 6/7] arm64: dts: imx93: add lpi2c nodes

From: Krzysztof Kozlowski
Date: Fri Aug 12 2022 - 06:10:04 EST


On 12/08/2022 10:46, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@xxxxxxx>
>
> Add i.MX93 lpi2c nodes
>
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> ---
> arch/arm64/boot/dts/freescale/imx93.dtsi | 89 ++++++++++++++++++++++++
> 1 file changed, 89 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
> index fd687d78cd03..3d1309d393a4 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -16,6 +16,14 @@ / {
> #size-cells = <2>;
>
> aliases {
> + i2c0 = &lpi2c1;
> + i2c1 = &lpi2c2;
> + i2c2 = &lpi2c3;
> + i2c3 = &lpi2c4;
> + i2c4 = &lpi2c5;
> + i2c5 = &lpi2c6;
> + i2c6 = &lpi2c7;
> + i2c7 = &lpi2c8;

i2c aliases are property of the board.
https://lore.kernel.org/linux-rockchip/CAK8P3a25iYksubCnQb1-e5yj=crEsK37RB9Hn4ZGZMwcVVrG7g@xxxxxxxxxxxxxx/

> mmc0 = &usdhc1;
> mmc1 = &usdhc2;
> mmc2 = &usdhc3;
> @@ -138,6 +146,26 @@ system_counter: timer@44290000 {
> clock-names = "per";
> };
>
> + lpi2c1: i2c@44340000 {
> + compatible = "fsl,imx93-lpi2c", "fsl,imx7ulp-lpi2c";

Undocumented compatible.

> + reg = <0x44340000 0x10000>;
> + interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clk IMX93_CLK_LPI2C1_GATE>,
> + <&clk IMX93_CLK_BUS_AON>;
> + clock-names = "per", "ipg";
> + status = "disabled";
> + };
> +


(...)

> + lpi2c8: i2c@426e0000 {
> + compatible = "fsl,imx93-lpi2c", "fsl,imx7ulp-lpi2c";
> + reg = <0x426e0000 0x10000>;
> + interrupts = <GIC_SPI 198 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clk IMX93_CLK_LPI2C8_GATE>,
> + <&clk IMX93_CLK_BUS_WAKEUP>;
> + clock-names = "per", "ipg";
> + status = "disabled";
> + };
> +

No need for blank line



Best regards,
Krzysztof