Re: [PATCH v4 0/3] xen-blk{back,front}: Fix two bugs in 'feature_persistent'

From: Juergen Gross
Date: Fri Aug 12 2022 - 06:08:15 EST


On 16.07.22 00:51, SeongJae Park wrote:
Introduction of 'feature_persistent' made two bugs. First one is wrong
overwrite of 'vbd->feature_gnt_persistent' in 'blkback' due to wrong
parameter value caching position, and the second one is unintended
behavioral change that could break previous dynamic frontend/backend
persistent feature support changes. This patchset fixes the issues.

Changes from v3
(https://lore.kernel.org/xen-devel/20220715175521.126649-1-sj@xxxxxxxxxx/)
- Split 'blkback' patch for each of the two issues
- Add 'Reported-by: Andrii Chepurnyi <andrii.chepurnyi82@xxxxxxxxx>'

Changes from v2
(https://lore.kernel.org/xen-devel/20220714224410.51147-1-sj@xxxxxxxxxx/)
- Keep the behavioral change of v1
- Update blkfront's counterpart to follow the changed behavior
- Update documents for the changed behavior

Changes from v1
(https://lore.kernel.org/xen-devel/20220106091013.126076-1-mheyne@xxxxxxxxx/)
- Avoid the behavioral change
(https://lore.kernel.org/xen-devel/20220121102309.27802-1-sj@xxxxxxxxxx/)
- Rebase on latest xen/tip/linux-next
- Re-work by SeongJae Park <sj@xxxxxxxxxx>
- Cc stable@

Maximilian Heyne (1):
xen-blkback: Apply 'feature_persistent' parameter when connect

SeongJae Park (2):
xen-blkback: fix persistent grants negotiation
xen-blkfront: Apply 'feature_persistent' parameter when connect

.../ABI/testing/sysfs-driver-xen-blkback | 2 +-
.../ABI/testing/sysfs-driver-xen-blkfront | 2 +-
drivers/block/xen-blkback/xenbus.c | 20 ++++++++-----------
drivers/block/xen-blkfront.c | 4 +---
4 files changed, 11 insertions(+), 17 deletions(-)


For the series:

Reviewed-by: Juergen Gross <jgross@xxxxxxxx>


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature