Re: [PATCH] mm/uffd: Reset write protection when unregister with wp-mode

From: Andrew Morton
Date: Thu Aug 11 2022 - 18:01:18 EST


On Thu, 11 Aug 2022 17:23:14 -0400 Peter Xu <peterx@xxxxxxxxxx> wrote:

> On Thu, Aug 11, 2022 at 02:11:44PM -0700, Andrew Morton wrote:
> > On Thu, 11 Aug 2022 16:13:40 -0400 Peter Xu <peterx@xxxxxxxxxx> wrote:
> >
> > > I added a Fixes upon introducing of uffd-wp shmem+hugetlbfs because that's
> > > the only issue reported so far and that's the commit David's reproducer
> > > will start working (v5.19+). But the whole idea actually applies to not
> > > only file memories but also anonymous. It's just that we don't need to fix
> > > anonymous prior to v5.19- because there's no known way to exploit.
> >
> > I added a cc:stable to this.
>
> Thanks, Andrew. I'll remember to do so in future patches when Fixes apply.
>

Only if we want the fix to be backported!

I mean, it's legitimate and sensible to add a Fixes: to a patch which
fixes a comment typo, but we don't want that backported.

And sometimes a fix is too complex and the problem too small to warrant
a backport, but we still want that Fixes: tag.