Re: [PATCH v3 4/4] platform/x86: simatic-ipc: enable watchdog for 227G

From: Hans de Goede
Date: Thu Aug 11 2022 - 14:53:32 EST


Hi,

On 8/11/22 17:39, Henning Schild wrote:
> Just load the watchdog module, after having identified that machine.
> That watchdog module does not have any autoloading support.
>
> Signed-off-by: Henning Schild <henning.schild@xxxxxxxxxxx>

Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Patches which are added to review-hans now are intended for
the next rc1. This branch will get rebased to the next rc1 when
it is out and after the rebasing the contents of review-hans
will be pushed to the platform-drivers-x86/for-next branch.

Regards,

Hans


> ---
> drivers/platform/x86/simatic-ipc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/platform/x86/simatic-ipc.c b/drivers/platform/x86/simatic-ipc.c
> index 1825ef21a86d..8dd686d1c9f1 100644
> --- a/drivers/platform/x86/simatic-ipc.c
> +++ b/drivers/platform/x86/simatic-ipc.c
> @@ -96,6 +96,9 @@ static int register_platform_devices(u32 station_id)
> ipc_wdt_platform_device->name);
> }
>
> + if (station_id == SIMATIC_IPC_IPC227G)
> + request_module("w83627hf_wdt");
> +
> if (ledmode == SIMATIC_IPC_DEVICE_NONE &&
> wdtmode == SIMATIC_IPC_DEVICE_NONE) {
> pr_warn("unsupported IPC detected, station id=%08x\n",