Re: [PATCH net 1/1] net: macsec: Fix XPN properties passing to macsec offload

From: Jakub Kicinski
Date: Thu Aug 11 2022 - 12:52:55 EST


On Tue, 9 Aug 2022 13:29:05 +0300 Emeel Hakim wrote:
> Currently macsec invokes HW offload path before reading extended
> packet number (XPN) related user properties i.e. salt and short
> secure channel identifier (ssci), hence preventing macsec XPN HW
> offload.
>
> Fix by moving macsec XPN properties reading prior to HW offload path.
>
> Fixes: 48ef50fa866a ("macsec: Netlink support of XPN cipher suites")
> Reviewed-by: Raed Salem <raeds@xxxxxxxxxx>
> Signed-off-by: Emeel Hakim <ehakim@xxxxxxxxxx>

Is there a driver in the tree which uses those values today?
I can't grep out any rx_sa->key accesses in the drivers at all :S

If there is none it's not really a fix.