Re: [PATCH] iio: light: Add raw attribute

From: Jonathan Cameron
Date: Thu Aug 11 2022 - 09:25:27 EST


On Thu, 11 Aug 2022 15:44:43 +0530
Shreeya Patel <shreeya.patel@xxxxxxxxxxxxx> wrote:

> Add IIO_CHAN_INFO_RAW to the mask to be able to read raw values
> from the light sensor.

Why is this useful? It's rare to support _PROCESSED and _RAW for the same channel.
Normally occurred to avoid breaking ABI.

Jonathan

>
> Signed-off-by: Shreeya Patel <shreeya.patel@xxxxxxxxxxxxx>
> ---
> drivers/iio/light/ltrf216a.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/iio/light/ltrf216a.c b/drivers/iio/light/ltrf216a.c
> index e6e24e70d2b9..a717bf99bd2a 100644
> --- a/drivers/iio/light/ltrf216a.c
> +++ b/drivers/iio/light/ltrf216a.c
> @@ -93,6 +93,7 @@ static const struct iio_chan_spec ltrf216a_channels[] = {
> {
> .type = IIO_LIGHT,
> .info_mask_separate =
> + BIT(IIO_CHAN_INFO_RAW) |
> BIT(IIO_CHAN_INFO_PROCESSED) |
> BIT(IIO_CHAN_INFO_INT_TIME),
> .info_mask_separate_available =
> @@ -259,6 +260,18 @@ static int ltrf216a_read_raw(struct iio_dev *indio_dev,
> int ret;
>
> switch (mask) {
> + case IIO_CHAN_INFO_RAW:
> + ret = ltrf216a_set_power_state(data, true);
> + if (ret)
> + return ret;
> + mutex_lock(&data->lock);
> + ret = ltrf216a_read_data(data, LTRF216A_ALS_DATA_0);
> + mutex_unlock(&data->lock);
> + if (ret < 0)
> + return ret;
> + *val = ret;
> + ltrf216a_set_power_state(data, false);
> + return IIO_VAL_INT;
> case IIO_CHAN_INFO_PROCESSED:
> mutex_lock(&data->lock);
> ret = ltrf216a_get_lux(data);