Re: [PATCH net] bonding: fix reference count leak in balance-alb mode

From: Nikolay Aleksandrov
Date: Thu Aug 11 2022 - 04:04:10 EST


On 11/08/2022 08:06, Jay Vosburgh wrote:
> Commit d5410ac7b0ba ("net:bonding:support balance-alb interface
> with vlan to bridge") introduced a reference count leak by not releasing
> the reference acquired by ip_dev_find(). Remedy this by insuring the
> reference is released.
>
> Fixes: d5410ac7b0ba ("net:bonding:support balance-alb interface with vlan to bridge")
> Signed-off-by: Jay Vosburgh <jay.vosburgh@xxxxxxxxxxxxx>
>
> ---
> drivers/net/bonding/bond_alb.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
> index 60cb9a0225aa..b9dbad3a8af8 100644
> --- a/drivers/net/bonding/bond_alb.c
> +++ b/drivers/net/bonding/bond_alb.c
> @@ -668,8 +668,11 @@ static struct slave *rlb_arp_xmit(struct sk_buff *skb, struct bonding *bond)
>
> dev = ip_dev_find(dev_net(bond->dev), arp->ip_src);
> if (dev) {
> - if (netif_is_bridge_master(dev))
> + if (netif_is_bridge_master(dev)) {
> + dev_put(dev);
> return NULL;
> + }
> + dev_put(dev);
> }
>
> if (arp->op_code == htons(ARPOP_REPLY)) {

Nice catch,
Reviewed-by: Nikolay Aleksandrov <razor@xxxxxxxxxxxxx>