RE: [PATCH v10 5/9] bpf: Add bpf_lookup_*_key() and bpf_key_put() kfuncs

From: Roberto Sassu
Date: Thu Aug 11 2022 - 03:47:05 EST


> From: Alexei Starovoitov [mailto:alexei.starovoitov@xxxxxxxxx]
> Sent: Wednesday, August 10, 2022 11:34 PM
> On Wed, Aug 10, 2022 at 06:59:28PM +0200, Roberto Sassu wrote:
> > +
> > +static int __init bpf_key_sig_kfuncs_init(void)
> > +{
> > + int ret;
> > +
> > + ret = register_btf_kfunc_id_set(BPF_PROG_TYPE_TRACING,
> > + &bpf_key_sig_kfunc_set);
> > + if (!ret)
> > + return 0;
> > +
> > + return register_btf_kfunc_id_set(BPF_PROG_TYPE_LSM,
> > + &bpf_key_sig_kfunc_set);
>
> Isn't this a watery water ?
> Don't you have a patch 1 ?
> What am I missing ?

Uhm, yes. I had doubts too. That was what also KP did.

It makes sense to register once, since we mapped LSM to
TRACING.

Will resend only this patch. And I will figure out why CI failed.

Roberto