Re: [RFC PATCH 2/3] KVM: x86: Generate set of VMX feature MSRs using first/last definitions

From: Paolo Bonzini
Date: Wed Aug 10 2022 - 15:16:21 EST


On 8/10/22 16:40, Sean Christopherson wrote:
I'd rather move all the code to a new function kvm_init_feature_msr_list()
instead, and call it from kvm_arch_hardware_setup().

Would it make sense to also split out kvm_init_emulated_msr_list()? Hmm, and
rename this to kvm_init_virtualized_msr_list()? I can't tell if that would be
helpful or confusing.

I thought of feature MSRs because it's a different ioctl altogether, but this is not an objection; whatever seems less confusing to you.

Paolo