Re: [PATCH v2 1/3] dt-bindings: hwmon: Add IBM OCC bindings

[Rob Herring]

On Tue, Aug 9, 2022 at 2:07 PM Eddie James <eajames@xxxxxxxxxxxxx> wrote:
>
> These bindings describe the POWER processor On Chip Controller accessed
> from a service processor or baseboard management controller (BMC).
>
> Signed-off-by: Eddie James <eajames@xxxxxxxxxxxxx>
> ---
>  .../bindings/hwmon/ibm,occ-hwmon.yaml         | 39 +++++++++++++++++++
>  1 file changed, 39 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/ibm,occ-hwmon.yaml

What about Documentation/devicetree/bindings/hwmon/ibm,p8-occ-hwmon.txt?

> diff --git a/Documentation/devicetree/bindings/hwmon/ibm,occ-hwmon.yaml b/Documentation/devicetree/bindings/hwmon/ibm,occ-hwmon.yaml
> new file mode 100644
> index 000000000000..3dbdc5af2804
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/ibm,occ-hwmon.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/ibm,occ-hwmon.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: IBM On-Chip Controller (OCC) accessed from a service processor
> +
> +maintainers:
> +  - Eddie James <eajames@xxxxxxxxxxxxx>
> +
> +description: |

Don't need '|' if there is no formatting.

> +  The POWER processor On-Chip Controller (OCC) helps manage power and
> +  thermals for the system. A service processor or baseboard management
> +  controller can query the OCC for it's power and thermal data to report

s/it's/its/

> +  through hwmon.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ibm,p9-occ-hwmon
> +      - ibm,p10-occ-hwmon
> +
> +  ibm,no-poll-on-init:
> +    description: This property describes whether or not the OCC should
> +      be polled during driver initialization.
> +    type: boolean
> +
> +required:
> +  - compatible
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    hwmon {
> +        compatible = "ibm,p10-occ-hwmon";
> +        ibm,no-poll-on-init;

How does one access this device? There is no address.

> +    };

> --
> 2.31.1
>