Re: [PATCH v1 2/2] PCI: dwc: add support for 64-bit MSI target address

From: kernel test robot
Date: Wed Aug 10 2022 - 13:19:53 EST


Hi Will,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on helgaas-pci/next]
[also build test ERROR on linus/master next-20220810]
[cannot apply to v5.19]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Will-McVicker/PCI-dwc-Add-support-for-64-bit-MSI-target-addresses/20220810-020421
base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: sparc-buildonly-randconfig-r004-20220810 (https://download.01.org/0day-ci/archive/20220811/202208110116.R0hD7l2c-lkp@xxxxxxxxx/config)
compiler: sparc-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/7a41faa4e02a0a8945f79e7af86d10e371b2fc12
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Will-McVicker/PCI-dwc-Add-support-for-64-bit-MSI-target-addresses/20220810-020421
git checkout 7a41faa4e02a0a8945f79e7af86d10e371b2fc12
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> drivers/pci/controller/dwc/pcie-designware.c:85:5: error: redefinition of 'dw_pcie_msi_capabilities'
85 | u16 dw_pcie_msi_capabilities(struct dw_pcie *pci)
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/pci/controller/dwc/pcie-designware.c:20:
drivers/pci/controller/dwc/pcie-designware.h:467:19: note: previous definition of 'dw_pcie_msi_capabilities' with type 'u16(struct dw_pcie *)' {aka 'short unsigned int(struct dw_pcie *)'}
467 | static inline u16 dw_pcie_msi_capabilities(struct dw_pcie *pci)
| ^~~~~~~~~~~~~~~~~~~~~~~~


vim +/dw_pcie_msi_capabilities +85 drivers/pci/controller/dwc/pcie-designware.c

84
> 85 u16 dw_pcie_msi_capabilities(struct dw_pcie *pci)
86 {
87 u8 offset;
88
89 offset = dw_pcie_find_capability(pci, PCI_CAP_ID_MSI);
90 return dw_pcie_readw_dbi(pci, offset + PCI_MSI_FLAGS);
91 }
92 EXPORT_SYMBOL_GPL(dw_pcie_msi_capabilities);
93

--
0-DAY CI Kernel Test Service
https://01.org/lkp