Re: [PATCH] Input: joystick: xpad: Add X-Box Adaptive Controller support
From: kernel test robot
Date: Wed Aug 10 2022 - 02:09:18 EST
Hi Nate,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on dtor-input/next]
[also build test WARNING on hid/for-next linus/master v5.19 next-20220810]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Nate-Yocom/Input-joystick-xpad-Add-X-Box-Adaptive-Controller-support/20220810-082302
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
config: x86_64-randconfig-a016 (https://download.01.org/0day-ci/archive/20220810/202208101406.tS1Uz1FD-lkp@xxxxxxxxx/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 5f1c7e2cc5a3c07cbc2412e851a7283c1841f520)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/4c3757fab74082cf845405ba8d8b2d60e06572cd
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Nate-Yocom/Input-joystick-xpad-Add-X-Box-Adaptive-Controller-support/20220810-082302
git checkout 4c3757fab74082cf845405ba8d8b2d60e06572cd
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash arch/x86/entry/ drivers/input/joystick/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All warnings (new ones prefixed by >>):
>> drivers/input/joystick/xpad.c:1643:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
default:
^
drivers/input/joystick/xpad.c:1643:2: note: insert '__attribute__((fallthrough));' to silence this warning
default:
^
__attribute__((fallthrough));
drivers/input/joystick/xpad.c:1643:2: note: insert 'break;' to avoid fall-through
default:
^
break;
1 warning generated.
vim +1643 drivers/input/joystick/xpad.c
^1da177e4c3f41 drivers/usb/input/xpad.c Linus Torvalds 2005-04-16 1618
deb8ee43a23d48 drivers/usb/input/xpad.c Dominic Cerquetti 2006-10-10 1619 static void xpad_set_up_abs(struct input_dev *input_dev, signed short abs)
deb8ee43a23d48 drivers/usb/input/xpad.c Dominic Cerquetti 2006-10-10 1620 {
1a48ff81b3912b drivers/input/joystick/xpad.c Ted Mielczarek 2014-08-08 1621 struct usb_xpad *xpad = input_get_drvdata(input_dev);
68c78d0155e379 drivers/input/joystick/xpad.c Leo Sperling 2016-08-03 1622
deb8ee43a23d48 drivers/usb/input/xpad.c Dominic Cerquetti 2006-10-10 1623 switch (abs) {
deb8ee43a23d48 drivers/usb/input/xpad.c Dominic Cerquetti 2006-10-10 1624 case ABS_X:
deb8ee43a23d48 drivers/usb/input/xpad.c Dominic Cerquetti 2006-10-10 1625 case ABS_Y:
deb8ee43a23d48 drivers/usb/input/xpad.c Dominic Cerquetti 2006-10-10 1626 case ABS_RX:
deb8ee43a23d48 drivers/usb/input/xpad.c Dominic Cerquetti 2006-10-10 1627 case ABS_RY: /* the two sticks */
deb8ee43a23d48 drivers/usb/input/xpad.c Dominic Cerquetti 2006-10-10 1628 input_set_abs_params(input_dev, abs, -32768, 32767, 16, 128);
deb8ee43a23d48 drivers/usb/input/xpad.c Dominic Cerquetti 2006-10-10 1629 break;
deb8ee43a23d48 drivers/usb/input/xpad.c Dominic Cerquetti 2006-10-10 1630 case ABS_Z:
b45d44e7e00c17 drivers/input/joystick/xpad.c Nicolas Léveillé 2009-12-29 1631 case ABS_RZ: /* the triggers (if mapped to axes) */
1a48ff81b3912b drivers/input/joystick/xpad.c Ted Mielczarek 2014-08-08 1632 if (xpad->xtype == XTYPE_XBOXONE)
1a48ff81b3912b drivers/input/joystick/xpad.c Ted Mielczarek 2014-08-08 1633 input_set_abs_params(input_dev, abs, 0, 1023, 0, 0);
1a48ff81b3912b drivers/input/joystick/xpad.c Ted Mielczarek 2014-08-08 1634 else
deb8ee43a23d48 drivers/usb/input/xpad.c Dominic Cerquetti 2006-10-10 1635 input_set_abs_params(input_dev, abs, 0, 255, 0, 0);
deb8ee43a23d48 drivers/usb/input/xpad.c Dominic Cerquetti 2006-10-10 1636 break;
deb8ee43a23d48 drivers/usb/input/xpad.c Dominic Cerquetti 2006-10-10 1637 case ABS_HAT0X:
b45d44e7e00c17 drivers/input/joystick/xpad.c Nicolas Léveillé 2009-12-29 1638 case ABS_HAT0Y: /* the d-pad (only if dpad is mapped to axes */
deb8ee43a23d48 drivers/usb/input/xpad.c Dominic Cerquetti 2006-10-10 1639 input_set_abs_params(input_dev, abs, -1, 1, 0, 0);
deb8ee43a23d48 drivers/usb/input/xpad.c Dominic Cerquetti 2006-10-10 1640 break;
4c3757fab74082 drivers/input/joystick/xpad.c Nate Yocom 2022-08-09 1641 case ABS_MISC: /* 4 value layer button (such as on the XAC) */
4c3757fab74082 drivers/input/joystick/xpad.c Nate Yocom 2022-08-09 1642 input_set_abs_params(input_dev, abs, 0, 4, 0, 0);
a01308031c2647 drivers/input/joystick/xpad.c Marcus Folkesson 2018-05-08 @1643 default:
a01308031c2647 drivers/input/joystick/xpad.c Marcus Folkesson 2018-05-08 1644 input_set_abs_params(input_dev, abs, 0, 0, 0, 0);
a01308031c2647 drivers/input/joystick/xpad.c Marcus Folkesson 2018-05-08 1645 break;
deb8ee43a23d48 drivers/usb/input/xpad.c Dominic Cerquetti 2006-10-10 1646 }
deb8ee43a23d48 drivers/usb/input/xpad.c Dominic Cerquetti 2006-10-10 1647 }
deb8ee43a23d48 drivers/usb/input/xpad.c Dominic Cerquetti 2006-10-10 1648
--
0-DAY CI Kernel Test Service
https://01.org/lkp