Re: [PATCH] asm-generic: Conditionally enable do_softirq_own_stack() via Kconfig.

From: Arnd Bergmann
Date: Tue Aug 09 2022 - 17:43:23 EST


On Tue, Aug 9, 2022 at 5:57 PM Sebastian Andrzej Siewior
<bigeasy@xxxxxxxxxxxxx> wrote:
>
> Remove the CONFIG_PREEMPT_RT symbol from the ifdef around
> do_softirq_own_stack() and move it to Kconfig instead.
>
> Enable softirq stacks based on SOFTIRQ_ON_OWN_STACK which depends on
> HAVE_SOFTIRQ_ON_OWN_STACK and its default value is set to !PREEMPT_RT.
> This ensures that softirq stacks are not used on PREEMPT_RT and avoids
> a 'select' statement on an option which has a 'depends' statement.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> ---
> arch/Kconfig | 4 ++++
> arch/arm/kernel/irq.c | 2 +-
> arch/parisc/kernel/irq.c | 2 +-
> arch/powerpc/kernel/irq.c | 4 ++--
> arch/s390/include/asm/softirq_stack.h | 2 +-
> arch/sh/kernel/irq.c | 2 +-
> arch/sparc/kernel/irq_64.c | 2 +-
> arch/x86/include/asm/irq_stack.h | 2 +-
> arch/x86/kernel/irq_32.c | 2 +-
> include/asm-generic/softirq_stack.h | 2 +-

Thanks for the patch, I assume Linus will want to pick this up himself.
Let me know if I should give it a spin in the asm-generic tree first for
additional build testing.

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>