Re: [PATCH] perf tools: Fix missing free of machine->kallsyms_filename

From: Ian Rogers
Date: Tue Aug 09 2022 - 12:51:30 EST


On Tue, Aug 9, 2022 at 6:08 AM Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote:
>
> Add missing free of machine->kallsyms_filename to machine__exit().
>
> Fixes: a5367ecb5353 ("perf tools: Automatically use guest kcore_dir if present")
> Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>

Acked-by: Ian Rogers <irogers@xxxxxxxxxx>

Thanks,
Ian

> ---
> tools/perf/util/machine.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
> index facc13fbf16e..2a16cae28407 100644
> --- a/tools/perf/util/machine.c
> +++ b/tools/perf/util/machine.c
> @@ -236,6 +236,7 @@ void machine__exit(struct machine *machine)
> zfree(&machine->root_dir);
> zfree(&machine->mmap_name);
> zfree(&machine->current_tid);
> + zfree(&machine->kallsyms_filename);
>
> for (i = 0; i < THREADS__TABLE_SIZE; i++) {
> struct threads *threads = &machine->threads[i];
> --
> 2.25.1
>