Re: [PATCH v1 1/5] regmap: mmio: Don't unprepare attached clock

From: Mark Brown
Date: Mon Aug 08 2022 - 09:48:42 EST


On Mon, Aug 08, 2022 at 03:41:48PM +0200, Andy Shevchenko wrote:
> On Mon, Aug 8, 2022 at 3:19 PM Mark Brown <broonie@xxxxxxxxxx> wrote:

> > regmap_mmio_attach_clk() prepares the clock that's passed in, we should
> > undo that when detaching otherwise we're leaking a prepare (as we do in
> > the explicit detach).

> Why do we allow the user to avoid explicit detach? What is the point
> of having that API in the case we take care of it?

I think just for symmetry so it's obvious that error handling is
happening if people want it to be.

Attachment: signature.asc
Description: PGP signature