Re: [PATCH V3 4/6] dt-bindings: clk: meson: add S4 SoC peripheral clock controller bindings

From: Yu Tu
Date: Mon Aug 08 2022 - 06:01:48 EST


Hi Krzysztof,

On 2022/8/8 14:16, Krzysztof Kozlowski wrote:
[ EXTERNAL EMAIL ]

On 05/08/2022 11:33, Yu Tu wrote:
Hi Krzysztof,
Thank you for your reply.

On 2022/8/5 17:15, Krzysztof Kozlowski wrote:
[ EXTERNAL EMAIL ]

On 05/08/2022 10:57, Yu Tu wrote:
Add peripheral clock controller compatible and dt-bindings header for
the of the S4 SoC.

Signed-off-by: Yu Tu <yu.tu@xxxxxxxxxxx>
---
.../bindings/clock/amlogic,s4-clkc.yaml | 92 ++++++++++++
include/dt-bindings/clock/amlogic,s4-clkc.h | 131 ++++++++++++++++++
2 files changed, 223 insertions(+)
create mode 100644 Documentation/devicetree/bindings/clock/amlogic,s4-clkc.yaml
create mode 100644 include/dt-bindings/clock/amlogic,s4-clkc.h

diff --git a/Documentation/devicetree/bindings/clock/amlogic,s4-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,s4-clkc.yaml
new file mode 100644
index 000000000000..2471276afda9
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/amlogic,s4-clkc.yaml

Filename should be based on compatible, so amlogic,s4-periphs-clkc.yaml
I will correct as you suggest in the next version.

@@ -0,0 +1,92 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/amlogic,s4-clkc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Amlogic Meson S serials Peripheral Clock Controller Device Tree Bindings

s/Device Tree Bindings//
what's mean?

It's a expression (simplified not accurate) from many Linux tools, e.g.
sed, vim etc
s/SEARCH/REPLACE/
so just drop that piece I wrote above.
Do you mean you need me to delete "Device Tree Bindings"?


Best regards,
Krzysztof

.