Re: [PATCH v2] dt-binding: ipmi: add fallback to npcm845 compatible

[Krzysztof Kozlowski]

On 07/08/2022 18:05, Corey Minyard wrote:
>> We had a disscation with Arnd, Arnd asked us to use a fallback as we
>> did here if NPCM8XX device module is similar to NPCM7XX module:
>> https://lore.kernel.org/lkml/20220522155046.260146-5-tmaimon77@xxxxxxxxx/
>>
>> I think we should use a fallback to describe the NPCM8XX KCS in the
>> dt-binding document.
> 
> I'm ok with that option.  I guess I should have mentioned it.  Add
> nuvoton,npcm-kcs-bmc to the driver's of_device_id table. 

To be clear - NAK. It's not a specific compatible, therefore it is not
appropriate at all.

> Then use that
> in that compatible string in the device tree.  Leave the 750 compatible
> string in the table for backwards compatibility.
> 
> There's no point in having a bunch of those strings if they are all the
> same.  If a new one comes out that is different, we can handle that when
> the time comes.\
There is a point. It's exactly how we do in all DT bindings. It is
recommended by writing bindings document.

Best regards,
Krzysztof