Re: [PATCH 1/5] asus-wmi: Add basic support for TUF laptop keyboard RGB

From: Andy Shevchenko
Date: Sat Aug 06 2022 - 06:28:32 EST


On Sat, Aug 6, 2022 at 12:27 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Sat, Aug 6, 2022 at 12:16 PM Luke Jones <luke@xxxxxxxxxx> wrote:
> > On Sat, Aug 6 2022 at 11:44:33 +0200, Andy Shevchenko
> > <andy.shevchenko@xxxxxxxxx> wrote:
> > > On Fri, Aug 5, 2022 at 10:20 AM Luke D. Jones <luke@xxxxxxxxxx> wrote:

...

> > >> #include <linux/leds.h>
> > >> +#include <linux/led-class-multicolor.h>
> > >
> > > Not sure about the ordering ('-' vs. 's') in locale C.
> >
> > I used hid-playstation.c as a reference and followed that ordering.
>
> Try something like this:
>
> LC_ALL=c sort

Should be, of course,

LC_ALL=C sort

> for these two lines and see if the ordering is the same.

--
With Best Regards,
Andy Shevchenko