Re: [PATCH v2] dt-binding: ipmi: add fallback to npcm845 compatible

From: Krzysztof Kozlowski
Date: Fri Aug 05 2022 - 02:36:48 EST


On 04/08/2022 20:18, Tomer Maimon wrote:
> Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible
> string becuase NPCM845 and NPCM750 BMCs are using identical KCS modules.
>
> Signed-off-by: Tomer Maimon <tmaimon77@xxxxxxxxx>

Your previous commit adding that compatible was simply wrong and not
matching the driver and it is not the first time. I think all Nuvoton
patches need much more careful review :(

You forgot the fixes tag:

Fixes: 84261749e58a ("dt-bindings: ipmi: Add npcm845 compatible")




Best regards,
Krzysztof