Re: [PATCH] misc: bcm_vk: Remove usage of deprecated functions

[Scott Branden]

Unsure, you may need to add Greg K-H to the to email for him to see this 
patch as he picks up misc drivers in his tree.

On 2022-07-27 04:14, Breno Leitao wrote:
> From: Breno Leitao <leitao@xxxxxxxxxx>
>
> ida_simple_get() and ida_simple_remove() functions are deprecated now.
> These functions were replaced by ida_alloc() and ida_free()
> respectively. This patch modernizes the bcm_vk driver to use the
> replacement functions.
>
> Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx>
Acked-by: Scott Branden <scott.branden@xxxxxxxxxxxx>
> ---
>   drivers/misc/bcm-vk/bcm_vk_dev.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/misc/bcm-vk/bcm_vk_dev.c b/drivers/misc/bcm-vk/bcm_vk_dev.c
> index a16b99bdaa13..a3a82ebbc699 100644
> --- a/drivers/misc/bcm-vk/bcm_vk_dev.c
> +++ b/drivers/misc/bcm-vk/bcm_vk_dev.c
> @@ -1401,7 +1401,7 @@ static int bcm_vk_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>   		bcm_vk_tty_set_irq_enabled(vk, i);
>   	}
>   
> -	id = ida_simple_get(&bcm_vk_ida, 0, 0, GFP_KERNEL);
> +	id = ida_alloc(&bcm_vk_ida, GFP_KERNEL);
>   	if (id < 0) {
>   		err = id;
>   		dev_err(dev, "unable to get id\n");
> @@ -1500,7 +1500,7 @@ static int bcm_vk_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>   	misc_device->name = NULL;
>   
>   err_ida_remove:
> -	ida_simple_remove(&bcm_vk_ida, id);
> +	ida_free(&bcm_vk_ida, id);
>   
>   err_irq:
>   	for (i = 0; i < vk->num_irqs; i++)
> @@ -1573,7 +1573,7 @@ static void bcm_vk_remove(struct pci_dev *pdev)
>   	if (misc_device->name) {
>   		misc_deregister(misc_device);
>   		kfree(misc_device->name);
> -		ida_simple_remove(&bcm_vk_ida, vk->devid);
> +		ida_free(&bcm_vk_ida, vk->devid);
>   	}
>   	for (i = 0; i < vk->num_irqs; i++)
>   		devm_free_irq(&pdev->dev, pci_irq_vector(pdev, i), vk);

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature