Re: [PATCH linux-next] w1: omap-hdq:using the pm_runtime_resume_and_get to simplify the code

[Christophe JAILLET]

Le 03/08/2022 à 08:11, cgel.zte@xxxxxxxxx a écrit :
> From: ye xingchen <ye.xingchen@xxxxxxxxxx>
>
> Using pm_runtime_resume_and_get() to instade of
>   pm_runtime_get_sync and pm_runtime_put_noidle.
>
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: ye xingchen <ye.xingchen@xxxxxxxxxx>
> ---
>   drivers/w1/masters/omap_hdq.c | 18 ++++++------------
>   1 file changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c
> index bf2ec59c1f9d..ec4292bc0458 100644
> --- a/drivers/w1/masters/omap_hdq.c
> +++ b/drivers/w1/masters/omap_hdq.c
> @@ -372,9 +372,8 @@ static u8 omap_w1_triplet(void *_hdq, u8 bdir)
>   		  OMAP_HDQ_CTRL_STATUS_INTERRUPTMASK;
>   	u8 mask = ctrl | OMAP_HDQ_CTRL_STATUS_DIR;
>   
> -	err = pm_runtime_get_sync(hdq_data->dev);
> +	err = pm_runtime_resume_and_get(hdq_data->dev);
>   	if (err < 0) {
> -		pm_runtime_put_noidle(hdq_data->dev);
>   
>   		return err;
>   	}

I don't have a strong opinion on the patch itself, but the resulting 
would look like:
	err = pm_runtime_resume_and_get(hdq_data->dev);
   	if (err < 0) {

   		return err;
   	}

which is odd. { } and extra blank line should be removed, IMHO.

CJ

[...]