Re: [PATCH -next] f2fs: Replace kmalloc() with f2fs_kmalloc

From: Joe Perches
Date: Mon Aug 01 2022 - 21:42:52 EST


On Mon, 2022-08-01 at 11:23 -0700, Christoph Hellwig wrote:
> On Mon, Aug 01, 2022 at 05:22:02PM +0800, studentxswpy@xxxxxxx wrote:
> > From: Xie Shaowen <studentxswpy@xxxxxxx>
> >
> > replace kmalloc with f2fs_kmalloc to keep f2fs code consistency.
>
> For that removing f2fs_kmalloc entirely would be way better.

Dunno, maybe doubtful as there's a specific "fault injector" test
built around f2fs_<foo>alloc. (CONFIG_F2FS_FAULT_INJECTION)

For a student lesson, it would significantly better to compile any
patch, especially to avoid broken patches, before submitting them.