Re: [PATCH v2 01/10] mfd: intel_soc_pmic: Fix an error handling path in intel_soc_pmic_i2c_probe()

[Andy Shevchenko]

On Mon, Aug 1, 2022 at 10:43 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> On 7/31/22 22:12, Andy Shevchenko wrote:

...

> >  err_del_irq_chip:
> > +     pwm_remove_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup));
> >       regmap_del_irq_chip(pmic->irq, pmic->irq_chip_data);
> >       return ret;
>
> Note alternatively we could just move the pwm_add_table() to just before the "return 0",
> there is no strict ordering between adding the mfd devices and the pwm_add_table()
> (the pwm device only becomes available after the pwm-driver has bound to the mfd
> instantiated platform device which happens later).
>
> IMHO that would be a bit cleaner.

Good suggestion!

Since I need to send a v3 anyway, I will fix this accordingly.

-- 
With Best Regards,
Andy Shevchenko