Re: [PATCH 2/2] kprobes: fix the comments error

From: Google
Date: Sun Jul 31 2022 - 10:37:46 EST


On Fri, 22 Jul 2022 14:25:05 +0800
zhangduo <zduo006@xxxxxxx> wrote:

> From: zhangduo <zhangduo@xxxxxxxxxx>
>
> fix the comments 'Copy the insn slot of ap to p'
>
> Signed-off-by: zhangduo <zhangduo@xxxxxxxxxx>

Looks good to me.

Acked-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>

Thanks,

> ---
> kernel/kprobes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index f1dddc8fe..8bcef7d3c 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -1349,7 +1349,7 @@ static int register_aggr_kprobe(struct kprobe *orig_p, struct kprobe *p)
> | KPROBE_FLAG_DISABLED;
> }
>
> - /* Copy the insn slot of 'p' to 'ap'. */
> + /* Copy the insn slot of 'ap' to 'p'. */
> copy_kprobe(ap, p);
> ret = add_new_kprobe(ap, p);
>
> --
> 2.25.1
>


--
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>