Re: [PATCH] iio: Use parens with sizeof

From: Jonathan Cameron
Date: Sun Jul 31 2022 - 07:20:36 EST


On Sun, 17 Jul 2022 11:34:38 -0400
Joe Simmons-Talbott <joetalbott@xxxxxxxxx> wrote:

> Prefer 'sizeof(var)' over 'sizeof var' as reported by checkpatch.pl.
>
> Signed-off-by: Joe Simmons-Talbott <joetalbott@xxxxxxxxx>
Applied to the togreg branch of iio.git and pushed out as testing
to let 0-day take a poke at it.

oops. Email got stuck in my outbox when I went away for a week.

Thanks,

Jonathan

> ---
> drivers/iio/industrialio-trigger.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/industrialio-trigger.c b/drivers/iio/industrialio-trigger.c
> index f504ed351b3e..88bccb0676c8 100644
> --- a/drivers/iio/industrialio-trigger.c
> +++ b/drivers/iio/industrialio-trigger.c
> @@ -368,7 +368,7 @@ struct iio_poll_func
> va_list vargs;
> struct iio_poll_func *pf;
>
> - pf = kmalloc(sizeof *pf, GFP_KERNEL);
> + pf = kmalloc(sizeof(*pf), GFP_KERNEL);
> if (pf == NULL)
> return NULL;
> va_start(vargs, fmt);
> @@ -560,7 +560,7 @@ struct iio_trigger *viio_trigger_alloc(struct device *parent,
> struct iio_trigger *trig;
> int i;
>
> - trig = kzalloc(sizeof *trig, GFP_KERNEL);
> + trig = kzalloc(sizeof(*trig), GFP_KERNEL);
> if (!trig)
> return NULL;
>