[steev:linux-v5.19.0-rc8-tests 68/182] drivers/gpu/drm/msm/dp/dp_hpd.c:63:53: warning: converting the enum constant to a boolean

From: kernel test robot
Date: Sun Jul 31 2022 - 05:24:17 EST


tree: https://github.com/steev/linux linux-v5.19.0-rc8-tests
head: 171125613e081f0d0d9aeb710dc7469ce2c6a219
commit: 69fde892d28706172f6cfa4ae11d81712521c84c [68/182] drm/msm/dp: Add typec_mux implementation
config: arm64-buildonly-randconfig-r005-20220731 (https://download.01.org/0day-ci/archive/20220731/202207311753.OE9Jwsti-lkp@xxxxxxxxx/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 52cd00cabf479aa7eb6dbb063b7ba41ea57bce9e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/steev/linux/commit/69fde892d28706172f6cfa4ae11d81712521c84c
git remote add steev https://github.com/steev/linux
git fetch --no-tags steev linux-v5.19.0-rc8-tests
git checkout 69fde892d28706172f6cfa4ae11d81712521c84c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/gpu/drm/msm/ drivers/interconnect/qcom/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/msm/dp/dp_hpd.c:63:53: warning: converting the enum constant to a boolean [-Wint-in-bool-context]
usbpd->multi_func = pin_assign == DP_PIN_ASSIGN_C || DP_PIN_ASSIGN_E;
^
1 warning generated.


vim +63 drivers/gpu/drm/msm/dp/dp_hpd.c

52
53 static int dp_hpd_mux_set(struct typec_mux_dev *mux, struct typec_mux_state *state)
54 {
55 struct dp_hpd_private *dp_hpd = typec_mux_get_drvdata(mux);
56 struct dp_usbpd *usbpd = &dp_hpd->dp_usbpd;
57 struct typec_displayport_data *dp_data = state->data;
58 int pin_assign = 0;
59
60 if (dp_data) {
61 pin_assign = DP_CONF_GET_PIN_ASSIGN(dp_data->conf);
62 usbpd->hpd_irq = !!(dp_data->status & DP_STATUS_IRQ_HPD);
> 63 usbpd->multi_func = pin_assign == DP_PIN_ASSIGN_C || DP_PIN_ASSIGN_E;
64 }
65
66 if (!pin_assign) {
67 if (dp_hpd->connected) {
68 dp_hpd->connected = false;
69 dp_hpd->dp_cb->disconnect(dp_hpd->dev);
70 }
71 } else if (!dp_hpd->connected) {
72 dp_hpd->connected = true;
73 dp_hpd->dp_cb->configure(dp_hpd->dev);
74 } else {
75 dp_hpd->dp_cb->attention(dp_hpd->dev);
76 }
77
78 return 0;
79 }
80

--
0-DAY CI Kernel Test Service
https://01.org/lkp