Re: [PATCH v5 2/6] scsi: ufs: wb: Change functions name and modify parameter name

From: Bart Van Assche
Date: Fri Jul 29 2022 - 16:22:47 EST


On 7/28/22 21:54, Jinyoung CHOI wrote:
-static inline void ufshcd_wb_config(struct ufs_hba *hba)
+static void ufshcd_wb_set_default_flags(struct ufs_hba *hba)

It is not clear to me why the new name is considered an improvement? The old name looks better to me. If you want to rename this function anyway, how about ufshcd_configure_wb()?

Thanks,

Bart.