Re: [PATCH v6 12/13] leds: flash: mt6370: Add MediaTek MT6370 flashlight support

From: Andy Shevchenko
Date: Fri Jul 29 2022 - 06:35:10 EST


On Fri, Jul 29, 2022 at 8:17 AM szuni chen <szunichen@xxxxxxxxx> wrote:
> Andy Shevchenko <andy.shevchenko@xxxxxxxxx> 於 2022年7月25日 週一 下午4:51寫道:
> > On Fri, Jul 22, 2022 at 12:25 PM ChiaEn Wu <peterwu.pub@xxxxxxxxx> wrote:
> > >
> > > From: Alice Chen <alice_chen@xxxxxxxxxxx>

...

> > > Signed-off-by: Alice Chen <alice_chen@xxxxxxxxxxx>
> >
> > This SoB chain is wrong. Prioritize and read Submitting Patches!
>
> After reading the Submitted Patches,
> ChiaEn Wu wasn't involved in the development but he submitted the patch,
> So, ChiaEn Wu <chiaen_wu@xxxxxxxxxxx> should be the last SoB, right?

Right. Submitter's SoB is the last SoB in the chain.

> I will revise SoB to
>
> Signed-off-by: SzuNi Chen <alice_chen@xxxxxxxxxxx>

Not sure I understand the SzuNi <--> Alice transformation...

> Signed-off-by: ChiaEn Wu <chiaen_wu@xxxxxxxxxxx>
>
> If there is anything else I need to fix, please let me know. Thank you.

--
With Best Regards,
Andy Shevchenko