Re: [PATCH v3 2/2] ufs: core: print UFSHCD capabilities in controller's sysfs node

From: Greg Kroah-Hartman
Date: Fri Jul 29 2022 - 04:32:25 EST


On Fri, Jul 29, 2022 at 06:29:45PM +1000, Daniil Lunev wrote:
> > >
> > > +What: /sys/bus/platform/drivers/ufshcd/*/capabilities/clock_scaling
> >
> > This shouldn't be linked to as a driver file, it's a device file. So no
> > need for this line.
> >
> > > +What: /sys/bus/platform/devices/*.ufs/capabilities/clock_scaling
> >
> > Since when are all ufs devices platform devices? Do we not have UFS
> > controllers on other types of busses?
>
> I have pretty much copped the structure of the entries across this file. Nearly
> all of the entries link both device and driver paths and nearly all of
> the entries
> mention the platform-based path (which you correctly mentioned is not
> factually correct, since we do have controllers on the pci bus). Please advise
> if it is ok to keep it like this for consistency or what would be the
> appropriate
> way to adjust the documentation?

Ah, ok, that's odd. Let's just leave this as-is for now, hopefully
someone else cleans this up later.

thanks,

greg k-h