Re: [PATCH v2] ufs: core: print capabilities in controller's sysfs node

From: Greg Kroah-Hartman
Date: Fri Jul 29 2022 - 03:20:36 EST


On Thu, Jul 28, 2022 at 04:23:16PM -0700, Bart Van Assche wrote:
> On 7/28/22 16:05, Daniil Lunev wrote:
> > +What: /sys/bus/platform/drivers/ufshcd/*/caps
> > +What: /sys/bus/platform/devices/*.ufs/caps
> > +Date: July 2022
> > +Contact: Daniil Lunev <dlunev@xxxxxxxxxxxx>
> > +Description: Read-only attribute. Enabled capabilities of the UFS driver. The
> > + enabled capabilities are determined by what is supported by the
> > + host controller and the UFS device.
> > + Format: 0x%08llx
>
> This documentation is useless since the meaning of the individual bits has
> not been documented.

Yeah, that's not ok, where are these bits coming from and what userspace
tools will be using them?

thanks,

greg k-h