Re: [PATCH] sched/net/act: Remove temporary state variables

From: Jiri Pirko
Date: Fri Jul 29 2022 - 03:00:18 EST


Fri, Jul 29, 2022 at 08:51:21AM CEST, kuba@xxxxxxxxxx wrote:
>On Fri, 29 Jul 2022 08:30:35 +0200 Jiri Pirko wrote:
>>> How many case like this are there in the kernel?
>>> What tool are you using to find this?
>>> We should focus on creating CI tools which can help catch instances of
>>> this pattern in new code before it gets added, rather than cleaning up
>>> old code. It just makes backports harder for hardly any gain.
>>
>> What backports do you have in mind exactly?
>
>Code backports. I don't understand the question.

Code backports of what where?
Are you talking about:
1) mainline kernels
2) distrubutions kernels? Or even worse, in-house kernels of companies?

If 2), I believe it is not relevant for the upstream discussion, at all.



>There's little benefit and we're getting multiple such patches a day.