Re: [PATCH] ufs: core: print capabilities in controller's sysfs node

[Bart Van Assche]

On 7/28/22 16:08, Daniil Lunev wrote:
> On Thu, Jul 28, 2022 at 11:37 PM Bart Van Assche <bvanassche@xxxxxxx> wrote:
> > This code change includes all of the UFSHCD_CAP_* constants in the
> > kernel ABI. Is that really what we want? I'm wondering whether it
> > perhaps would be better only to export those capabilities to user space
> > that user space needs to know about.
> Adding the filtering would introduce an extra maintenance burden and
> will likely go out
> of sync. I don't see harm in exposing all capabilities, both intrinsic
> to the controller and
> negotiated with the device. Do you see any scenario where that would be harmful?

Please only export what you need instead of exporting all capabilities.

Thanks,

Bart.