Re: [PATCH v2 0/3] New driver for Intel(Altera) FPGA System ID softIP

From: Greg KH
Date: Thu Jul 28 2022 - 03:58:16 EST


On Thu, Jul 21, 2022 at 08:30:19PM +0800, kah.jing.lee@xxxxxxxxx wrote:
> From: Kah Jing Lee <kah.jing.lee@xxxxxxxxx>
>
> Hi,
>
> I would like to request review for the new System ID driver for Intel FPGA
> platform.
>
> New sysid driver for Altera(Intel) Sysid component is generally part of an
> FPGA design. The component can be hotplugged when the FPGA is reconfigured.
>
> There are two basic ways to use the system ID core:
> - Verify the system ID before downloading new software to a system. This
> method can be used by software development tools, before downloading a
> program to a target hardware system, if the program is compiled for
> different hardware.
>
> - Check system ID after reset. If a program is running on hardware other
> than the expected Platform Designer system, the program may fail to
> function altogether. If the program does not crash, it can behave
> erroneously in subtle ways that are difficult to debug. To protect against
> this case, a program can compare the expected system ID against the
> system ID core, and report an error if they do not match.
>
> Documentation link:
> https://rocketboards.org/foswiki/Documentation/AgilexSoCGSRD#PR_Files
>
> Feedback from maintainers:
> https://lore.kernel.org/lkml/YpmqeHt5Y31ffh5Q@xxxxxxxxx/#t

That does not describe what changed from the previous version at all, it
just points to a response from me saying you all need to work on this
driver.

thanks,

greg k-h