Re: [PATCH v4] erofs: update ctx->pos for every emitted dirent

From: Gao Xiang
Date: Wed Jul 27 2022 - 06:04:58 EST


On Fri, Jul 22, 2022 at 04:27:32PM +0800, Jeffle Xu wrote:
> From: Hongnan Li <hongnan.li@xxxxxxxxxxxxxxxxx>
>
> erofs_readdir update ctx->pos after filling a batch of dentries
> and it may cause dir/files duplication for NFS readdirplus which
> depends on ctx->pos to fill dir correctly. So update ctx->pos for
> every emitted dirent in erofs_fill_dentries to fix it.
>
> Also fix the update of ctx->pos when the initial file position has
> exceeded nameoff.
>
> Fixes: 3e917cc305c6 ("erofs: make filesystem exportable")
> Signed-off-by: Hongnan Li <hongnan.li@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Jeffle Xu <jefflexu@xxxxxxxxxxxxxxxxx>

Reviewed-by: Gao Xiang <hsiangkao@xxxxxxxxxxxxxxxxx>

Thanks,
Gao Xiang