RE: [PATCH v1 4/8] media: ov2740: Remove duplicate check for NULL fwnode

[Cao, Bingbu]

Hi, Andy

Thanks for your patch.

Reviewed-by: Bingbu Cao <bingbu.cao@xxxxxxxxx>

________________________
BRs,  
Bingbu Cao 

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Sent: Tuesday, July 26, 2022 8:06 PM
> To: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>; linux-
> media@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Cc: Qiu, Tian Shu <tian.shu.qiu@xxxxxxxxx>; Tu, ShawnX
> <shawnx.tu@xxxxxxxxx>; Cao, Bingbu <bingbu.cao@xxxxxxxxx>; Mauro Carvalho
> Chehab <mchehab@xxxxxxxxxx>
> Subject: [PATCH v1 4/8] media: ov2740: Remove duplicate check for NULL
> fwnode
> 
> fwnode API does proper checks and returns correct codes, no need to repeat
> it in the caller.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>  drivers/media/i2c/ov2740.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c index
> 9420258c6073..07fe8fda274e 100644
> --- a/drivers/media/i2c/ov2740.c
> +++ b/drivers/media/i2c/ov2740.c
> @@ -1009,9 +1009,6 @@ static int ov2740_check_hwcfg(struct device *dev)
>  	int ret;
>  	unsigned int i, j;
> 
> -	if (!fwnode)
> -		return -ENXIO;
> -
>  	ret = fwnode_property_read_u32(fwnode, "clock-frequency", &mclk);
>  	if (ret)
>  		return ret;
> --
> 2.35.1