Re: [PATCH v2 2/2] reset: tps380x: Add TPS380x device driver supprt

From: Philipp Zabel
Date: Wed Jul 27 2022 - 05:14:52 EST


Hi Marco,

On Di, 2022-07-26 at 10:45 +0200, Marco Felsch wrote:
> Hi Philipp,
>
> gentle ping.

Applied to reset/next.

I've taken liberty to remove the TODO comment, see below:

> On 22-05-30, Marco Felsch wrote:
[...]
> > + /*
> > + * Todo:
> > + * Add firmware handling to switch between min/typ/max reset time
> > + */

I've dropped this because I think waiting for max reset time is the
only way to guarantee correctness, if we expect that tps3801 delay
times actually vary between min and max reset time (whether that is due
to production variance or temperature sensitivity).

If a board vendor can guarantee that the actual max delay on a given
board is less than the specified max reset time, this could be handled
via an optional device tree parameter to overrride the delay.

regards
Philipp
>