Re: [PATCH v2 6/7] dmaengine: hisilicon: Add dfx feature for hisi dma driver

[Jie Hai]

On 2022/7/26 20:39, Vinod Koul wrote:
> On 26-07-22, 09:43, Jie Hai wrote:
> > On 2022/7/21 21:25, Vinod Koul wrote:
> > > On 29-06-22, 11:55, Jie Hai wrote:
> > >
> > > What does dfx mean in title?
> > Thanks for the question.
> >
> > DFX＝"Design for X", I quote its definition as follows:
> > The product definition puts forward a list of specific aspects about a
> > design that designers need to optimize, for example, product usage,
> > functions and features, cost range, and aesthetics. Modern designers even
> > need to consider more design objectives because the new design
> > characteristics may finally determine the success or failure of a product.
> > Design methodologies that consider these new characteristics are called
> > design for X (DFX). Specific design methodologies include design for
> > reliability (DFR), design for serviceability (DFS), design for supply chain
> > (DFSC), design for scalability (DFSc), design for energy efficiency and
> > environment (DFEE), design for testability (DFT),and so on.
>
> This would be better to explain in changelog, not many people would be
> familiar with these terms...
Thanks. As I wrote below, I've replaced it in v3 with something easier 
to understand, which is "dump regs to debugfs".

> > For clarity, I've replaced it in v3 with something easier to understand.
> > > > This patch adds dump of registers with debugfs for HIP08
> > > > and HIP09 DMA driver.
> > > >
> > > > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > >
> > > ?
> > The kernel test robot raised an issue and asked me to modify it and add
> > "Reported-by: kernel test robot <lkp@xxxxxxxxx>" to the commit message, so I
> > did, and it was removed in v3.
>
> ok