Re: [PATCH V7 02/16] rv: Add runtime reactors interface
From: Steven Rostedt
Date: Tue Jul 26 2022 - 12:26:40 EST
On Mon, 25 Jul 2022 22:11:14 +0200
Daniel Bristot de Oliveira <bristot@xxxxxxxxxx> wrote:
> +/**
> + * reactor_cleanup_monitor - cleanup a monitor reference
> + * @mdef: monitor's definition.
> + */
> +void reactor_cleanup_monitor(struct rv_monitor_def *mdef)
> +{
> + mdef->rdef->counter--;
> +}
> +
Doesn't this require a lock? Also you might want to add a WARN_ONCE() if it
goes below zero.
-- Steve