Re: [PATCH 10/10] arm64: dts: qcom: sdm845: add LLCC BWMON

[Sibi Sankar]

On 7/26/22 5:01 PM, Sibi Sankar wrote:
> On 7/23/22 2:06 PM, Krzysztof Kozlowski wrote:
> > On 23/07/2022 04:37, Steev Klimaszewski wrote:
> > > > Currently it's 5.19.0-rc7 (torvalds tree at 4ba1329c) with a few extra
> > > > patches on top, the bwmon set included.  It's possible that secure
> > > > world uses it, but I do not know enough about that to say one way or
> > > > the other.
> >
> > To test patches you should apply them on maintainer's tree or
> > linux-next. Applying on other trees of course might be useful for
> > testing some backports, but it is independent process and different 
> > issue.
> >
> > > > -- steev
> > > I think you may be right; I just applied this patchset to -next
> > > (20220722) and i do not see the error message there.  On my 5.19-rc7
> > > tree, i am also testing a patchset that enables qcom devices to access
> > > efivars, so possibly we are ending up in secure world there?
> >
> > Actually mapping of IO space should not touch secure world, so this was
> > a long shot assuming you test it on the next.
>
> The memory region specified in device tree overlaps with the llcc system
> cache controller node. Steev probably had the QCOM_LLCC config enabled 
> when he tested it out on his branch.

From what I see we can probably get away with restricting the llcc_base
reg region to just llcc0_common region and leave the lcc-bwmon as is.

> > Best regards,
> > Krzysztof