Re: [PATCH v6 21/26] selftests: net/fcnal: Initial tcp_authopt support

From: Eric Dumazet
Date: Tue Jul 26 2022 - 03:07:17 EST


On Tue, Jul 26, 2022 at 8:16 AM Leonard Crestez <cdleonard@xxxxxxxxx> wrote:
>
> Tests are mostly copied from tcp_md5 with minor changes.
>
> It covers VRF support but only based on binding multiple servers: not
> multiple keys bound to different interfaces.
>
> Also add a specific -t tcp_authopt to run only these tests specifically.
>

Thanks for the test.

Could you amend the existing TCP MD5 test to make sure dual sockets
mode is working ?

Apparently, if we have a dual stack listener socket (AF_INET6),
correct incoming IPV4 SYNs are dropped.

If this is the case, fixing MD5 should happen first ;)

I think that we are very late in the cycle (linux-5.19 should be
released in 5 days), and your patch set should not be merged so late.

Thanks.

> Signed-off-by: Leonard Crestez <cdleonard@xxxxxxxxx>
> ---
>