Re: [PATCH 3/4] dt-bindings: mfd: Add bindings for Samsung SysMgr

[Dongjin Yang]

On 14/07/2022 04:28, Krzysztof Kozlowski wrote:
> On 13/07/2022 06:56, Dongjin Yang wrote:
> > Add an devicetree binding for Samsung system manager.
> > This driver is used for SoCs produced by Samsung Foundry to provide
> > Samsung sysmgr API. The read/write request of sysmgr is delivered to
> > Samsung secure monitor call.
> 
> Nope. Second patch with the same - you need to describe the hardware or
> underlying firmware, not the driver. "This driver" is not acceptable for
> bindings.
> 

Yes, I will describe the hardware and underlying firmware. 

> > 
> > Signed-off-by: Dongjin Yang <dj76.yang@xxxxxxxxxxx>
> > ---
> >  .../devicetree/bindings/mfd/samsung,sys-mgr.yaml   | 42 ++++++++++++++++++++++
> >  MAINTAINERS                                        |  1 +
> >  2 files changed, 43 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mfd/samsung,sys-mgr.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/samsung,sys-mgr.yaml b/Documentation/devicetree/bindings/mfd/samsung,sys-mgr.yaml
> > new file mode 100644
> > index 000000000000..83b9d73a5420
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/samsung,sys-mgr.yaml
> > @@ -0,0 +1,42 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: https://protect2.fireeye.com/v1/url?k=4e490fd5-2fc21afa-4e48849a-74fe485cbfe7-58c60ac4380837bf&q=1&e=f2eeb6c4-6c9d-40cd-9437-933a16218ac5&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Ffirmware%2Fsamsung%2Csys-mgr.yaml%23
> > +$schema: https://protect2.fireeye.com/v1/url?k=1c5b5e89-7dd04ba6-1c5ad5c6-74fe485cbfe7-8170c2ecb94e64e4&q=1&e=f2eeb6c4-6c9d-40cd-9437-933a16218ac5&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23
> > +
> > +title: Samsung System Manager
> > +
> > +maintainers:
> > +  - Jesper Nilsson <jesper.nilsson@xxxxxxxx>
> 
> How is this related to Axis platforms?
> 

This is for Artpec8 SoC.

> > +
> > +description: |
> > +  The file documents device tree bindings of Samsung system manager.
> 
> Useless description. Describe the hardw
> 

Yes, I will describe hardware (Artpec8).

> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - samsung,sys-mgr
> > +      - samsung,sys-mgr-smccc
> 
> Sorry, this does not look like hardware. It could be description of
> underlying firmware, but you would need to justify it. Look at Qualcomm
> SCM for example. Or ARM SCMI, SCPI.
> 

Yes, Should it be like the below? 

properties:
  compatible:
    enum:
      - axis,artpec8-sys-mgr
      - axis,artpec8-sys-mgr-smccc

> 
> Best regards,
> Krzysztof