Re: [PATCH 1/1] dt-bindings: mmc: sdhci-msm: Fix issues in yaml bindings

From: Bhupesh Sharma
Date: Mon Jul 25 2022 - 16:32:17 EST


Hi Rob,

On 7/2/22 3:36 AM, Rob Herring wrote:
On Sat, May 14, 2022 at 4:01 PM Bhupesh Sharma
<bhupesh.sharma@xxxxxxxxxx> wrote:

Rob pointed some remaining issues in the sdhci-msm yaml
bindings (via [1]).

Fix the same by first using the 'mmc-controller.yaml' as
'ref' and thereafter also fix the issues reported by
'make dtbs_check' check.

[1]. https://lore.kernel.org/linux-arm-msm/YnLmNCwNfoqZln12@xxxxxxxxxxxxxxxxxx/

Fixes: a45537723f4b ("dt-bindings: mmc: sdhci-msm: Convert bindings to yaml")
Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
Cc: Rob Herring <robh@xxxxxxxxxx>
Cc: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx>
---
-> This patch uses the dts changes sent (here: https://lore.kernel.org/linux-arm-msm/20220514215424.1007718-1-bhupesh.sharma@xxxxxxxxxx/), for fixing the dtbs_check errors.
-> This patch is rebased on 'linux-next/master'

.../devicetree/bindings/mmc/sdhci-msm.yaml | 52 ++++++++++++++++---
1 file changed, 44 insertions(+), 8 deletions(-)

There's another issue with this applied:

Documentation/devicetree/bindings/mmc/sdhci-msm.example.dtb:
mmc@8804000: Unevaluated properties are not allowed
('operating-points-v2' was unexpected)

Should just need a 'operating-points-v2: true' line.

This won't show up until a fix for 'unevaluatedProperties' handling is
applied. But first I need all the issues fixed.

Sorry, I totally missed this comment. I have sent a fix for the same via [1]. Please help review the same.

Thanks

[1]. https://lore.kernel.org/linux-arm-msm/20220725202709.2861789-1-bhupesh.sharma@xxxxxxxxxx/