Re: [PATCH] gpio: gpio-xilinx: Fix integer overflow

From: Andy Shevchenko
Date: Mon Jul 25 2022 - 16:30:23 EST


On Mon, Jul 25, 2022 at 10:21 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Mon, Jul 25, 2022 at 10:04 PM Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
> > On Fri, Jul 22, 2022 at 9:19 AM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> > > On Thu, Jul 21, 2022 at 9:39 AM Srinivas Neeli
> > > <srinivas.neeli@xxxxxxxxxx> wrote:

...

> Reading again... You mean that
>
> unsigned long x = y << 32;
>
> wouldn't work?

Yeah, I even checked this in asm, and indeed it doesn't work. Don't
know what was that about me...


Thanks for the fix,
Reviewed-by: Andy Shevchenko <andy.shevchenlko@xxxxxxxxx>


--
With Best Regards,
Andy Shevchenko