Re: [PATCH 1/2] powerpc: drop dependency on <asm/machdep.h> in archrandom.h

From: Michael Ellerman
Date: Mon Jul 25 2022 - 08:22:40 EST


Yury Norov <yury.norov@xxxxxxxxx> writes:
> archrandom.h includes <asm/machdep.h> to refer ppc_md. This causes
> circular header dependency, if generic nodemask.h includes random.h:
>
> In file included from include/linux/cred.h:16,
> from include/linux/seq_file.h:13,
> from arch/powerpc/include/asm/machdep.h:6,
> from arch/powerpc/include/asm/archrandom.h:5,
> from include/linux/random.h:109,
> from include/linux/nodemask.h:97,
> from include/linux/list_lru.h:12,
> from include/linux/fs.h:13,
> from include/linux/compat.h:17,
> from arch/powerpc/kernel/asm-offsets.c:12:
> include/linux/sched.h:1203:9: error: unknown type name 'nodemask_t'
> 1203 | nodemask_t mems_allowed;
> | ^~~~~~~~~~
>
> Fix it by removing <asm/machdep.h> dependency from archrandom.h
>
> Signed-off-by: Yury Norov <yury.norov@xxxxxxxxx>
> ---
> arch/powerpc/include/asm/archrandom.h | 9 +--------
> arch/powerpc/kernel/setup-common.c | 11 +++++++++++
> 2 files changed, 12 insertions(+), 8 deletions(-)

Acked-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>

cheers