Re: [PATCH v1 17/33] thermal/drivers/rcar: Switch to new of API

[Daniel Lezcano]

Hi Niklas,

On 25/07/2022 01:28, Niklas Söderlund wrote:
> Hi (again) Daniel,
>
> I figured it out, the thermal zone is disabled after this change. For
> both rcar sensors with the new API thermal_zone_device_enable() is never
> called.
>
> In the old API the zone is enabled in the call chain of
> devm_thermal_zone_of_sensor_register(). While after this change the zone
> is not enabled by the core when calling thermal_zone_device_enable().
>
> If I add a call to thermal_zone_device_enable() together with the new
> API everything works as before. But I'm not sure if the correct solution
> is to add a call to thermal_zone_device_enable() in the sensor drivers
> or in the call chain of the new API?
>
> On 2022-07-25 00:39:10 +0200, Niklas Söderlund wrote:
> > Hi Daniel,
> >
> > I tested your branch, unfortunately with the same result for
> > rcar_gen3_thermal. Manipulation of emul_temp file do not trigger
> > actions.

Thanks for investigating, I updated the branch. Does it fix the issue ?




--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog