Re: [PATCH v2 8/8] arm64: dts: mediatek: cherry: Enable MT6315 regulators on SPMI bus

From: Chen-Yu Tsai
Date: Mon Jul 25 2022 - 05:08:27 EST


On Thu, Jul 21, 2022 at 10:54 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@xxxxxxxxxxxxx> wrote:
>
> All machines in the Cherry platform use MT6315 over SPMI: add the
> two instances, providing Vbcpu and Vgpu regulators.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

Tested-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>

> ---
> .../boot/dts/mediatek/mt8195-cherry.dtsi | 42 +++++++++++++++++++
> 1 file changed, 42 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> index 9086a440a995..6219544e9912 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> @@ -5,6 +5,7 @@
>
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/leds/common.h>
> +#include <dt-bindings/spmi/spmi.h>
> #include "mt8195.dtsi"
> #include "mt6359.dtsi"
>
> @@ -979,6 +980,47 @@ usb_c1: connector@1 {
> };
> };
>
> +&spmi {
> + #address-cells = <2>;
> + #size-cells = <0>;
> +
> + mt6315@6 {
> + compatible = "mediatek,mt6315-regulator";
> + reg = <0x6 SPMI_USID>;
> +
> + regulators {
> + mt6315_6_vbuck1: vbuck1 {
> + regulator-compatible = "vbuck1";
> + regulator-name = "Vbcpu";
> + regulator-min-microvolt = <300000>;
> + regulator-max-microvolt = <1193750>;

Tinghan,

Could you help confirm these numbers? They must be valid for the
big cluster supply, not the PMIC.

> + regulator-enable-ramp-delay = <256>;
> + regulator-ramp-delay = <6250>;
> + regulator-allowed-modes = <0 1 2>;
> + regulator-always-on;
> + };
> + };
> + };
> +
> + mt6315@7 {
> + compatible = "mediatek,mt6315-regulator";
> + reg = <0x7 SPMI_USID>;
> +
> + regulators {
> + mt6315_7_vbuck1: vbuck1 {
> + regulator-compatible = "vbuck1";
> + regulator-name = "Vgpu";
> + regulator-min-microvolt = <625000>;
> + regulator-max-microvolt = <1193750>;

Same here for the GPU.


Thanks
ChenYu


> + regulator-enable-ramp-delay = <256>;
> + regulator-ramp-delay = <6250>;
> + regulator-allowed-modes = <0 1 2>;
> + regulator-always-on;
> + };
> + };
> + };
> +};
> +
> &u3phy0 {
> status = "okay";
> };
> --
> 2.35.1
>
>