Re: [PATCH 0/2] arm64 defconfig: Get faddr2line working

From: John Garry
Date: Mon Jul 25 2022 - 02:51:02 EST


On 24/07/2022 21:35, Arnd Bergmann wrote:
Note: this is based on next-20220722 and it may be wiser to sync the
defconfig manually (instead of using 1/2). Indeed I am not sure what is
the policy is of sync'ing this anyway.
I only synchronized the 32-bit defconfig files in my tree, not the 64-bit
one. However, I can't really apply your patch 2/2 because you appear
to mix refreshing the order of the options with changes that remove
options that are gone after a 'savedefconfig', risking that we miss
other bugs as well, as seen from your diffstat:

1 file changed, 36 insertions(+), 48 deletions(-)

I have refreshed this one as well now, which on my tree gives me

1 file changed, 31 insertions(+), 31 deletions(-)

I am not sure what you are doing in this refresh - can you share the steps? I guess that you sync with the savedefconfig and then manually edit the resultant defconfig to restore the configs which were getting deleting (and not just moved around).

For me - as you may expect - I do the following for the sync:
make defconfig
make savedefconfig
mv defconfig arch/arm64/configs/defconfig


for a nonfunction change. I have left the other ones untouched
for the moment:

CONFIG_ARCH_BCMBCA=y
CONFIG_SECCOMP=y
CONFIG_QRTR=m
CONFIG_PINCTRL_MSM=y
CONFIG_SND_SOC_TEGRA210_OPE=m
CONFIG_MAILBOX=y
CONFIG_QCOM_ICC_BWMON=m
CONFIG_SLIMBUS=m
CONFIG_INTERCONNECT=y
CONFIG_CONFIGFS_FS=y

These should be checked manually to find out why savedefconfig
no longer shows them, it could be either a bug (a new dependency,
renamed option, a driver randomly selects another subsystem, etc)
that we need to fix, or a harmless change (driver was removed,
option is now intended to be default-enabled, ...)

If you want to help more, can you check some or all of the above
and send patches to either re-enable the options or remove them
individually with explanations about why they are no longer
part of the savedefconfig output?

ok, I can check them.

Thanks,
John