Re: [PATCH -next] ALSA: hda: cs35l41: Fix build error unused-function

From: Takashi Iwai
Date: Mon Jul 25 2022 - 02:33:02 EST


On Mon, 25 Jul 2022 04:36:11 +0200,
Ren Zhijie wrote:
>
> If CONFIG_PM_SLEEP is not set,
> make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-, will be failed, like this:
>
> sound/pci/hda/cs35l41_hda.c:583:12: error: ʽcs35l41_runtime_resumeʼ defined but not used [-Werror=unused-function]
> static int cs35l41_runtime_resume(struct device *dev)
> ^~~~~~~~~~~~~~~~~~~~~~
> sound/pci/hda/cs35l41_hda.c:565:12: error: ʽcs35l41_runtime_suspendʼ defined but not used [-Werror=unused-function]
> static int cs35l41_runtime_suspend(struct device *dev)
> ^~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make[3]: *** [sound/pci/hda/cs35l41_hda.o] Error 1
>
> commit 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros,
> deprecate old ones"), add new marco RUNTIME_PM_OPS to fix this unused-function problem.
>
> Fixes: 1873ebd30cc8 ("ALSA: hda: cs35l41: Support Hibernation during Suspend")
> Signed-off-by: Ren Zhijie <renzhijie2@xxxxxxxxxx>

Thanks, applied.


Takashi